Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for the server #1443

Open
5 tasks
Tracked by #1354
manuelwedler opened this issue Jun 17, 2024 · 0 comments
Open
5 tasks
Tracked by #1354

Add additional tests for the server #1443

manuelwedler opened this issue Jun 17, 2024 · 0 comments

Comments

@manuelwedler
Copy link
Collaborator

follow-up of #1429

I found parts of the server for which it would be nice to add additional tests. We generally want to increase our test coverage. The following parts need additional tests (all inside server/src/server folder):

  • server.ts: Rate limiting (lines 194 - 234) should be tested
  • session.ts: Memory session is not tested
  • controllers/verification/session-state/session-state.handlers.ts: In this file, we should test adding remote files (line 35), and the addInputContractEndpoint is completely uncovered.
  • services/compiler/lambda and services/compiler/lambda-with-fallback: These are not covered at all.
  • services/storageServices/AllianceDatabaseService.ts is not really tested. Generally, we want to have separate tests for the different storage services. It would be nice to add these as part of this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants