You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried hard to avoid prepare_report.py having to parse CLI output and fish ICEs out of it. Instead it just checks whether it can find the artifacts. No artifacts == error. The filter is only necessary for Standard JSON to ignore inconsistent artifacts.
But actually, turns out that this was not the cause. The script had a bug - it was not looking at the exit code, which for CLI is another indication that something went wrong. The script originally only handled Standard JSON and there the exit code does not matter. When I was adding CLI support later, I must have forgotten to add a check for that.
See also #14510 (comment)
Remaining fixes before we can have green CI and merge the prototype:
UnimplementedFeatureError
.IMO we should fix CLI and Standard JSON do not generate the same outputs in case of errors at code generation stage #13925, but there's no consensus that this is the best approach and working around this inprepare_report.py
will probably be quicker to do.prepare_report.py
ignoring compiler exit code #14731The text was updated successfully, but these errors were encountered: