Remove dialect from yul compilability checker run arguments

Author: clonker

libyul/CompilabilityChecker.cpp

@@ -31,13 +31,12 @@ using namespace solidity::yul;
 using namespace solidity::util;
 
 CompilabilityChecker::CompilabilityChecker(
-	Dialect const& _dialect,
 	Object const& _object,
 	bool _optimizeStackAllocation
 )
 {
 	yulAssert(_object.hasCode());
-	if (auto const* evmDialect = dynamic_cast<EVMDialect const*>(&_dialect))
+	if (auto const* evmDialect = dynamic_cast<EVMDialect const*>(_object.dialect()))
 	{
 		NoOutputEVMDialect noOutputDialect(*evmDialect);
 

libyul/CompilabilityChecker.h

@@ -45,7 +45,6 @@ namespace solidity::yul
 struct CompilabilityChecker
 {
 	CompilabilityChecker(
-		Dialect const& _dialect,
 		Object const& _object,
 		bool _optimizeStackAllocation
 	);

libyul/optimiser/StackCompressor.cpp

@@ -276,7 +276,7 @@ std::tuple<bool, Block> StackCompressor::run(
 		{
 			Object object(_object);
 			object.setCode(std::make_shared<AST>(*_object.dialect(), std::get<Block>(ASTCopier{}(astRoot))));
-			std::map<YulName, int> stackSurplus = CompilabilityChecker(*object.dialect(), object, _optimizeStackAllocation).stackDeficit;
+			std::map<YulName, int> stackSurplus = CompilabilityChecker(object, _optimizeStackAllocation).stackDeficit;
 			if (stackSurplus.empty())
 				return std::make_tuple(true, std::move(astRoot));
 			eliminateVariables(

libyul/optimiser/StackLimitEvader.cpp

@@ -143,7 +143,6 @@ Block StackLimitEvader::run(
 	else
 	{
 		run(_context, astRoot, CompilabilityChecker{
-			_context.dialect,
 			_object,
 			true,
 		}.unreachableVariables);

test/libyul/CompilabilityChecker.cpp

@@ -34,16 +34,12 @@ namespace
 {
 std::string check(std::string const& _input)
 {
-	auto const& dialect = EVMDialect::strictAssemblyForEVM(
-		solidity::test::CommonOptions::get().evmVersion(),
-		solidity::test::CommonOptions::get().eofVersion()
-	);
 	Object obj;
 	auto parsingResult = yul::test::parse(_input);
 	obj.setCode(parsingResult.first, parsingResult.second);
 	BOOST_REQUIRE(obj.hasCode());
 	BOOST_REQUIRE(obj.dialect());
-	auto functions = CompilabilityChecker(dialect, obj, true).stackDeficit;
+	auto functions = CompilabilityChecker(obj, true).stackDeficit;
 	std::string out;
 	for (auto const& function: functions)
 		out += function.first.str() + ": " + std::to_string(function.second) + " ";

test/libyul/YulOptimizerTestCommon.cpp

@@ -434,7 +434,6 @@ YulOptimizerTestCommon::YulOptimizerTestCommon(
 			Object object(*m_optimizedObject);
 			object.setCode(std::make_shared<AST>(*m_dialect, std::get<Block>(ASTCopier{}(block))));
 			auto const unreachables = CompilabilityChecker{
-				*m_dialect,
 				object,
 				true
 			}.unreachableVariables;

test/tools/ossfuzz/StackReuseCodegenFuzzer.cpp

@@ -56,7 +56,6 @@ bool recursiveFunctionExists(Dialect const& _dialect, yul::Object& _object)
 {
 	auto recursiveFunctions = CallGraphGenerator::callGraph(_object.code()->root()).recursiveFunctions();
 	for(auto&& [function, variables]: CompilabilityChecker{
-			_dialect,
 			_object,
 			true
 		}.unreachableVariables