Skip to content

Commit c0bf6f1

Browse files
committed
eof: Address review comments
1 parent b4ad6b4 commit c0bf6f1

File tree

43 files changed

+149
-301
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+149
-301
lines changed

test/libsolidity/semanticTests/builtinFunctions/eof/keccak256_packed_complex_types.sol

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ contract C {
1111
}
1212
}
1313
// ====
14-
// EVMVersion: >=prague
1514
// bytecodeFormat: >=EOFv1
1615
// ----
1716
// f() -> 0xba4f20407251e4607cd66b90bfea19ec6971699c03e4a4f3ea737d5818ac27ae, 0xba4f20407251e4607cd66b90bfea19ec6971699c03e4a4f3ea737d5818ac27ae, true

test/libsolidity/semanticTests/constructor/callvalue_check.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ contract B4 { constructor() {} }
1111
contract C {
1212
function createWithValue(bytes memory c, uint256 value) public payable returns (bool) {
1313
uint256 y = 0;
14+
// TODO: This test is hard to recreate for EOF as for now eofcreate is disallowed in inline assembly.
1415
assembly { y := create(value, add(c, 0x20), mload(c)) }
1516
return y != 0;
1617
}

test/libsolidity/semanticTests/constructor/eof/no_callvalue_check.sol

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,5 @@ contract C {
1717
}
1818
// ====
1919
// bytecodeFormat: >=EOFv1
20-
// EVMVersion: >=prague
2120
// ----
2221
// f(), 2000 ether -> true
23-
// gas irOptimized: 117623
24-
// gas irOptimized code: 1800
25-
// gas legacy: 117821
26-
// gas legacy code: 4800
27-
// gas legacyOptimized: 117690
28-
// gas legacyOptimized code: 4800

test/libsolidity/semanticTests/deployedCodeExclusion/bound_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
function longdata(S memory) pure returns (bytes memory) {
23
return
34
"xasopca.pngaibngidak.jbtnudak.cAP.BRRSMCPJAGPD KIAJDOMHUKR,SCPID"

test/libsolidity/semanticTests/deployedCodeExclusion/library_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
library L {
23
function longdata() pure internal returns (bytes memory) {
34
return

test/libsolidity/semanticTests/deployedCodeExclusion/module_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
==== Source: mod.sol ====
23
function longdata() pure returns (bytes memory) {
34
return

test/libsolidity/semanticTests/deployedCodeExclusion/static_base_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
abstract contract S {
23
function longdata() internal pure returns (bytes memory) {
34
return

test/libsolidity/semanticTests/deployedCodeExclusion/subassembly_deduplication.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
contract A {
23
function longdata() pure external returns (bytes memory) {
34
return

test/libsolidity/semanticTests/deployedCodeExclusion/super_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
abstract contract S {
23
function longdata() internal pure returns (bytes memory) {
34
return

test/libsolidity/semanticTests/deployedCodeExclusion/virtual_function.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// TODO: Recreate this test for EOF when subassembly deduplication will be supported for EOF too.
12
abstract contract S {
23
function longdata() internal virtual pure returns (bytes memory);
34
}

0 commit comments

Comments
 (0)