Skip to content

Ensure that tests work even if /tmp is not accessible #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
axic opened this issue Jan 24, 2022 · 2 comments · Fixed by #591
Closed

Ensure that tests work even if /tmp is not accessible #588

axic opened this issue Jan 24, 2022 · 2 comments · Fixed by #591
Assignees
@adi611
Labels
enhancement good first issue

Comments

@axic
Copy link
Member

axic commented Jan 24, 2022 •
edited
Loading

test/compiler.js assumes that /tmp is always accessible. We should use a function that creates a temporary dir instead.

Originally posted by @cameel in #566 (comment)
@axic axic mentioned this issue Jan 24, 2022
Merged
@adi611
Copy link
Contributor

adi611 commented Jan 24, 2022

Please assign me this issue.

@cameel
Copy link
Member

cameel commented Jan 24, 2022

Sure. Feel free to submit a PR!

@axic axic mentioned this issue Jan 25, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adi611 adi611

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Ensure that tests work even if /tmp is not accessible adi611/solc-js
3 participants
@axic @cameel @adi611