Skip to content

Solidity <0.4.20 creates incorrect contracts output when are file paths with colon in them; could wrapper repair this? #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
haltman-at opened this issue Oct 12, 2021 · 2 comments
Open

Solidity <0.4.20 creates incorrect contracts output when are file paths with colon in them; could wrapper repair this? #557

haltman-at opened this issue Oct 12, 2021 · 2 comments
Labels
enhancement help wanted

Comments

@haltman-at
Copy link

Filing this issue based on discussion in #555. Currently[0] Truffle repairs this (see this Truffle PR for more info), but over on #555 @cameel suggested that perhaps solc/wrapper should be reparing this. (And then the fix would apply to everyone, not just Truffle, and we could remove our code for repairing it.) So, filing this issue asking for that.

[0]Well, OK, as of when I write this the fix isn't released yet, but it is merged...
@haltman-at haltman-at mentioned this issue Oct 12, 2021
Closed
@cameel
Copy link
Member

cameel commented Oct 13, 2021

@chriseth says that this is ok in the wrapper so we'll add a workaround.

@haltman-at
Copy link
Author

Nice, thanks!

@cameel cameel added this to solc-js Jun 10, 2022
@cameel cameel moved this to TODO in solc-js Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
No open projects
solc-js
Status: Implement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cameel @haltman-at