Skip to content

Add proper unit tests to translate.js #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
axic opened this issue Nov 25, 2019 · 3 comments
Open

Add proper unit tests to translate.js #414

axic opened this issue Nov 25, 2019 · 3 comments

Comments

@axic
Copy link
Member

axic commented Nov 25, 2019

This should be in the form of providing fixtures, the JSON outputs from previous compiler versions, and comparing that against and expected translation.

At least the versions listed in https://github.com/ethereum/solc-js/blob/master/test/compiler.js#L643-L650 should be included.

@qwloh
Copy link

qwloh commented Apr 2, 2022

Hey I'm interested to work on this. Can I claim this issue?

@cameel
Copy link
Member

cameel commented Apr 2, 2022

Sure! Go ahead.

The link in the description is now outdated but looks like it was pointing at this list that's now in test/compiler.ts.

Also, just a heads up, we're currently in the process of transitioning to TypeScript, which is being done by @stephensli. Fortunately I see that his upcoming PR (#614) does not touch translate.ts at all and that file does not depend on other files from that PR so I think there should be no interference.

@qwloh
Copy link

qwloh commented Apr 2, 2022

Okay! Will try to submit a PR within the next few days.

@cameel cameel added this to solc-js Jun 10, 2022
@cameel cameel moved this to Implement in solc-js Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implement
Development

No branches or pull requests

3 participants