Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Pinned contracts view. #5105

Closed
yann300 opened this issue Aug 22, 2024 · 12 comments · Fixed by #5207
Closed

UX: Pinned contracts view. #5105

yann300 opened this issue Aug 22, 2024 · 12 comments · Fixed by #5207
Assignees

Comments

@yann300
Copy link
Contributor

yann300 commented Aug 22, 2024

This view takes too much space when there is no pinned contract.

@Aniket-Engg
Copy link
Collaborator

Possible options:

  • We don't show it if there are no pinned contracts
  • Reduce message length
  • Reduce padding and margins

@ryestew
Copy link
Collaborator

ryestew commented Aug 22, 2024

In Deploy & Run, if nothing is deployed, it currently shows this:
image

I think we had the top part showing as a promo for pinning. Anyway it is a sort of promo for pinning - but now that pinning has been up for 3 months or more, its time to reduce the promos. So I don't think we should show anything if there are no pinned contracts. The pin icon will do that as well as the title, "Deployed/Unpinned contracts"

Just to show the pin icon - its pretty clear

image
  • maybe the tooltip can be expanded to:
    "Pinned contracts will be loaded after the page is refreshed."
    (is it the page or the browser or Remix)

@LianaHus
Copy link
Collaborator

I would suggest not to remove it completely. It is still informative. We could show the number of pinned/deployed contracts near each title(0 if nothing is to show). And add the message as a tooltip.

@Aniket-Engg
Copy link
Collaborator

We should discuss it in next UX meeting

@ryestew
Copy link
Collaborator

ryestew commented Sep 4, 2024

image

@ryestew
Copy link
Collaborator

ryestew commented Sep 4, 2024

There are 2 sections 1. Pinned Contracts 2. Deployed Contracts
We could just say
for Pinned Contracts (and include the network)(but we don't currently mention the workspace - but that's OK)
"No deployed contracts pinned to this Workspace & network"

for Deployed Contracts (unpinned is too awkward a word - so let's just leave it out)(unpin as a verb is awkward but makes sense. Unpinned as an adjective takes too much thought to decipher) .

Either:
No contracts here or Empty or None

@vermouth22 - your take?

@ryestew
Copy link
Collaborator

ryestew commented Sep 4, 2024

plus @Aniket-Engg - Reduce padding and margins

@vermouth22
Copy link
Collaborator

Yes, I agree.

Pinned Contracts
"No deployed contracts pinned to this Workspace and network"

Deployed Contracts
"No contracts here"

@Aniket-Engg
Copy link
Collaborator

@LianaHus Can you also share your views?

@LianaHus
Copy link
Collaborator

Screenshot from 2024-09-05 10-06-00
I'll put this here as well

@LianaHus
Copy link
Collaborator

Deploy and Run (4)

@LianaHus
Copy link
Collaborator

Deploy and Run (5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants