-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler doesn't check duplicated trait implementation #870
Comments
Hey @Y-Nak! Cool if I pick this up? Got an in-progress changeset I can probably cleanup later today that should resolve this.
|
Hey @BKDaugherty, thanks for fixing this problem. But this issue is already fixed in ongoing fe-v2 implementation, which will replace almost all v1 codebase. An issue is related to v2 implementation If it is labeled |
Oh awesome, glad it's already fixed! My bad, didn't realize this was already fixed in the fe-v2 implementation! I did base my branch off of fe-v2, and thought I reproduced the error. Is there a different way to invoke the fe-v2 implementation?
And no worries! It didn't take too long, I was mostly just excited to play around with the codebase :) |
yeah, it's complicated since v2 branch still maintains v1 codebase. I guess it'd be nice timing to remove them from the v2 branch(Initially, I thought it'd be cumbersome to resolve conflicts, but probably conflicts will no longer happen since we all are switching to v2). Is it ok to remove them after merging the To invoke the new driver, you need to specify it explicitly. |
|
The compiler doesn't check duplicated trait implementation for the same type.
Example
expected:
duplicate `impl` blocks for trait `Trait` for type `Foo`
actual: None
The text was updated successfully, but these errors were encountered: