Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

Bug in DAO example - transferFrom() required to fail? #659

Open
DavidKDeutsch opened this issue Sep 4, 2017 · 0 comments
Open

Bug in DAO example - transferFrom() required to fail? #659

DavidKDeutsch opened this issue Sep 4, 2017 · 0 comments

Comments

@DavidKDeutsch
Copy link

I have zero experience with solidity, but I'm pretty sure that the line(s) require (!t.transferFrom(_from, this, _value)); should not have the negation (!) in there. One of the code snippets uses a throw instead of a require, so my guess is the other lines used to use throw and the negation was accidentally left in there during the change to require.

The page I am referring to is at https://www.ethereum.org/dao.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant