Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config validations to each template that runs in CI #610

Open
Tracked by #396
blmalone opened this issue Feb 14, 2025 · 0 comments · May be fixed by #634
Open
Tracked by #396

Add config validations to each template that runs in CI #610

blmalone opened this issue Feb 14, 2025 · 0 comments · May be fixed by #634

Comments

@blmalone
Copy link
Contributor

blmalone commented Feb 14, 2025

Per this comment.

Got it, thank you. Another type of test we should have if we don't have it already, is config files of real templates. For example, we can have a ProtocolVersionsUpdate template, and a test config file specifies some random version strings to upgrade too. The ProtocolVersionsUpdate solidity template has validations, and CI runs the test config files for these real templates. This gives us confidence that our templates are always working and pass the validations

Permanently running them in CI because they're templates, that way we know templates always work and pass the assertions.


Our current regression tests use an older block. We want to make sure our templates are always useable from the latest block. By running a simulation from the task directory we can make sure the latest block is always used.

src/improvements/tasks/example/*:
- we have TOML files and .env file and README.md
- keep these as non terminal
- Have one example per template make sure it runs in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant