Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisig Task - Run template tests in CI #482

Open
Tracked by #396
ElliotFriedman opened this issue Jan 23, 2025 · 6 comments
Open
Tracked by #396

Multisig Task - Run template tests in CI #482

ElliotFriedman opened this issue Jan 23, 2025 · 6 comments

Comments

@ElliotFriedman
Copy link
Contributor

ElliotFriedman commented Jan 23, 2025

Run templates in CI to test that all templates still work.

Closed by: #488

@blmalone
Copy link
Contributor

Because we're trying to frequently merge to main, we're going to hold off on merging this CI feature to reduce the likelihood of it breaking and slowing down other teams that are reliant on superchain-ops.

@ElliotFriedman
Copy link
Contributor Author

This PR should fix this. I'm really struggling to see ways which this could hold other teams up as the nonces are not locked, so as long as the superchain-registry does not change, it should always work.

#487

@ElliotFriedman
Copy link
Contributor Author

Because we're trying to frequently merge to main, we're going to hold off on merging this CI feature to reduce the likelihood of it breaking and slowing down other teams that are reliant on superchain-ops.

Right now it is blocking mainnet so I would like to either get 487 merged, or move this to non-blocking for mainnet

@ElliotFriedman
Copy link
Contributor Author

One other thing that came to mind, even if we move this to non-blocking for mainnet, regression testing is currently blocking, which will in effect do the same thing, except at a specific block number.

@blmalone blmalone changed the title Multisig Task - Integration Test Tasks in CI Multisig Task - Run template tests in CI Jan 31, 2025
@ElliotFriedman
Copy link
Contributor Author

We should have this covered with the current integration test setup.

@ElliotFriedman
Copy link
Contributor Author

@blmalone just wanted to get your feelings on closing this as completed as the current integration tests in CI run tasks, just with forge script and not with forge test.

It would seem to me that the current testing setup makes this issue obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants