-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multisig Task - Run template tests in CI #482
Comments
Because we're trying to frequently merge to |
This PR should fix this. I'm really struggling to see ways which this could hold other teams up as the nonces are not locked, so as long as the superchain-registry does not change, it should always work. |
Right now it is blocking mainnet so I would like to either get 487 merged, or move this to non-blocking for mainnet |
One other thing that came to mind, even if we move this to non-blocking for mainnet, regression testing is currently blocking, which will in effect do the same thing, except at a specific block number. |
We should have this covered with the current integration test setup. |
@blmalone just wanted to get your feelings on closing this as completed as the current integration tests in CI run tasks, just with It would seem to me that the current testing setup makes this issue obsolete. |
Run templates in CI to test that all templates still work.
Closed by: #488
The text was updated successfully, but these errors were encountered: