Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Pad Improvements #6758

Open
Vringe opened this issue Nov 13, 2024 · 4 comments
Open

Delete Pad Improvements #6758

Vringe opened this issue Nov 13, 2024 · 4 comments

Comments

@Vringe
Copy link

Vringe commented Nov 13, 2024


name: Feature request
about: Improvements for the recently added "Delete Pad" Feature
title: 'Improvements for the recently added "Delete Pad" Feature'
labels: enhancement
assignees:


Thank you for adding the "Delete Pad" Button in 2.2.6. I think it would be a nice improvement, if the button is only visible for the owner of that pad. Also, some sort of confirmation message would be nice. Currently, it just disconnects you from the pad and you have to reload manually.

@Maksim-Burtsev
Copy link

i support the improvement of showing the button only for creator of the pad (maybe with a new setting).

for example in cases where pad created by api, users which use pad see this button but none of them have persmission to delete pad

@HarshDodiya1
Copy link

@Vringe
After deleting the pad, the application continues to display the popup shown below instead of navigating to another route. Also upon refreshing the page, the pad becomes editable again. Doesn't this seem like an error?

Do I have to create an issue for this?

image

@Vringe
Copy link
Author

Vringe commented Dec 4, 2024

@HarshDodiya1
Do you actually see the contents from before the deletion or just an empty pad? In my case, the pad is deleted and after reloading, you start with a fresh new pad. If you really see the old contents, it makes sense to create a separate issue for this.

My suggestion is to redirect to the start page (where you can create a new pad) and confirm the deletion with a toast message.

@HarshDodiya1
Copy link

@Vringe Yeah, facing the error, means when I delete the pad, it shows me pop up and when I refresh the page then again I am in the same pad. But I think when we delete the pad we should be redirected to the start page.

Currently it is this:

Etherpad.mp4

As you mention it will be good if we redirect to home page and see some toast of successful deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants