Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Prysm VC to REST API #1563

Open
nflaig opened this issue Oct 17, 2023 · 2 comments · May be fixed by #1569
Open

Switch Prysm VC to REST API #1563

nflaig opened this issue Oct 17, 2023 · 2 comments · May be fixed by #1569
Labels
enhancement New feature or request waiting for upstream

Comments

@nflaig
Copy link
Contributor

nflaig commented Oct 17, 2023

I am using eth-docker to do interop testing between Lodestar and other clients. For that I am using the vc only files which works great and makes interop testing really smooth but I noticed the prysm-vc-only.yml always has builder enabled and there is no option to enable the REST API which is required to work with other clients.

eth-docker/prysm-vc-only.yml

Line 71 in 38982d6

- --enable-builder

Wondering if it makes sense to support a interop mode for prysm, although I can't tell if anyone besides me would actually use that. If not I think this issue can be closed by just removing the builder flag as it is already set in the entrypoint script

eth-docker/prysm/docker-entrypoint-vc.sh

Lines 33 to 35 in 38982d6

if [ "${MEV_BOOST}" = "true" ]; then
__mev_boost="--enable-builder"
echo "MEV Boost enabled"

Just dropping my git diff here to make it work

diff --git a/prysm-vc-only.yml b/prysm-vc-only.yml
index 80dfc02..f5650eb 100644
--- a/prysm-vc-only.yml
+++ b/prysm-vc-only.yml
@@ -61,13 +61,15 @@ services:
       - --grpc-gateway-port
       - ${KEY_API_PORT:-7500}
       - --grpc-gateway-corsdomain=*
-      - --beacon-rpc-gateway-provider
-      - consensus:5052
+#      - --beacon-rpc-gateway-provider
+#      - consensus:5052
       - --suggested-fee-recipient
       - ${FEE_RECIPIENT}
-      - --enable-builder
       - --wallet-password-file
       - /var/lib/prysm/password.txt
+      - --beacon-rest-api-provider
+      - ${CL_NODE}
+      - --enable-beacon-rest-api
     labels:
       - traefik.enable=true
       - traefik.http.routers.prysm.entrypoints=web,websecure
@@ -140,8 +142,8 @@ services:
       - --${NETWORK}
       - --backup-dir=/validator_keys
       - --backup-password-file=/var/lib/prysm/password.txt
-    depends_on:
-      - consensus
+#    depends_on:
+#      - consensus

   validator-keys:
     profiles: ["tools"]
@yorickdowne
Copy link
Contributor

yorickdowne commented Oct 18, 2023 •
edited
Loading

Beacon REST API is still experimental for the VC, is it not? I am keen to switch Prysm to work with other CLs, but until that's the recommended way to run it, I'd rather not.

--enable-beacon-rest-api Experimental enable of the beacon REST API when querying a beacon node (default: false)

For now, you can make changes and git commit those for your testing runs, or create your own yml file and commit that.

@yorickdowne yorickdowne added the enhancement New feature or request label Oct 18, 2023
@nflaig
Copy link
Contributor Author

nflaig commented Oct 18, 2023

Beacon REST API is still experimental for the VC, is it not?

Yes, in fact, only their latest release works with Lodestar as there were some issues previously. Don't know about other clients. But I also don't think this can be a recommended mode right now for a wider audience. Attestations work quite well, haven't tested block production / sync committee yet.

For now, you can make changes and git commit those for your testing runs, or create your own yml file and commit that.

Sounds good, although I don't mind having local diff

@yorickdowne yorickdowne added help wanted Extra attention is needed waiting for upstream and removed help wanted Extra attention is needed labels Nov 5, 2023
@yorickdowne yorickdowne changed the title Prysm vc only always has builder enabled / client interop Switch Prysm vc to REST API Apr 24, 2024
@yorickdowne yorickdowne changed the title Switch Prysm vc to REST API Switch Prysm VC to REST API Apr 24, 2024
@yorickdowne yorickdowne linked a pull request Apr 30, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request waiting for upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prysm rest yorickdowne/eth-docker
2 participants
@nflaig @yorickdowne