New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChatMemberXXX redesign #2384

Open

Badiboy opened this issue Aug 17, 2024 · 3 comments

Labels

Collaborator

Badiboy commented Aug 17, 2024 •

edited

Loading

@coder2020official

Looks like we need to redesign ChatMemberXXX family. Currently we have all-in-one ChatMember, but it does not correspond to API.

https://core.telegram.org/bots/api#chatmember

I don't remeber why it is done like this now, I suppose we left it for compatibility...

Collaborator

coder2020official commented Aug 17, 2024

I'll take a look into it.

I don't remember any backward compatibility choices, though. All I remember is that Swiss was the one to implement it :)

Collaborator Author

Badiboy commented Aug 17, 2024

AFAIR some time before there was a single class ChatMember, which was later split into children. Thus we save full ChatMember to leave compatibility.

Collaborator

coder2020official commented Aug 19, 2024

not really having time rn. Could you do so?

coder2020official added the in the backlog label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment