Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release should not commit to master #21

Open
BelfordZ opened this issue Sep 19, 2019 · 0 comments
Open

semantic-release should not commit to master #21

BelfordZ opened this issue Sep 19, 2019 · 0 comments
Labels

Comments

@BelfordZ
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment, when semantic release is doing the publish step, it includes the changelog.

However, it also commits the changelog, and pushes this commit to master. Since master should be a protected branch, this presents some challenges that force us to loosen the rules, and to put powerful tokens in sketchy places.

Describe the solution you'd like
semantic-release should do everything on a release branch, opening a PR with the results instead of pushing them directly to master. This PR should be ignored by CI.

Describe alternatives you've considered
I've tried nothing and I'm all out of ideas.

Additional context
Perfection is the goal here ladies & non ladies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant