Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 (numpy-2.0) #937

Closed
suhas-r opened this issue Jan 5, 2025 · 3 comments
Closed

Support Python 3.12 (numpy-2.0) #937

suhas-r opened this issue Jan 5, 2025 · 3 comments

Comments

@suhas-r
Copy link
Contributor

suhas-r commented Jan 5, 2025

np.asfarray+np.float_ were removed in Numpy-2.0.0 (release notes) in favor of using np.asarray / np.float64, respectively. np.asarray + np.float64 are available in existing numpy>=1.24.2 versions currently required by the cnvkit conda env.

cnvkit otherwise functions properly withnumpy-2.* and python-3.12 after updating these methods.

Here's a PR: #934.

@suhas-r
Copy link
Contributor Author

suhas-r commented Jan 21, 2025

Hi @etal , thank you for merging in this PR last week! Is there a standard build process (+ anything I can assist with) to get a new version tagged so we can update cnvkit in our lab's apps?

@etal
Copy link
Owner

etal commented Jan 21, 2025

Is there a standard build process (+ anything I can assist with) to get a new version tagged so we can update cnvkit in our lab's apps?

Probably the easiest way to update CNVkit for your own apps is to install directly from the GitHub repo, as in:
https://pythonassets.com/posts/how-to-pip-install-from-a-git-repository/

For reproducibility you may want to append the current latest commit hash.

@suhas-r
Copy link
Contributor Author

suhas-r commented Jan 22, 2025

Makes sense, thank you

@suhas-r suhas-r closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants