Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esy-configure, esy-build assumes bash is at /bin/bash #51

Open
marcinkoziej opened this issue Aug 22, 2021 · 5 comments
Open

esy-configure, esy-build assumes bash is at /bin/bash #51

marcinkoziej opened this issue Aug 22, 2021 · 5 comments

Comments

@marcinkoziej
Copy link

#! /bin/bash

I am using esy on FreeBSD, where bash package is not available in base system, but installed into /usr/local/bin/bash. This breaks esy builds (for example when esy builds ocaml) because esy-configure fails.
The scripts should probably use #!/usr/bin/env bash to be versatile!

@Et7f3
Copy link

Et7f3 commented Sep 26, 2021

Does FreeBSD has /bin/sh ? I don't think we require bash

@marcinkoziej
Copy link
Author

It does!

@Et7f3
Copy link

Et7f3 commented Sep 27, 2021

So we might instead remove bash dependencies (I don't think we use any of bash features so you should be able to just replace the shebang. Can you replace and check you can compile ? Then do a PR

@Et7f3
Copy link

Et7f3 commented Sep 27, 2021

If any steps fail post and I will try to help.

@Et7f3
Copy link

Et7f3 commented Nov 6, 2021

This can be closed now for the version that will be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants