[SleepLog] screen refresh issues on banglejs 2

[m0n5t3r]

Affected hardware version

Bangle 2

Your firmware version

2v18

The bug

Everything updated, the sleep log app mangles the output when switching between days (left / right swipe), see image

expected behaviour: display texts properly, not have junk displayed on the left of the screen, or the "calculating data, please wait" text visible at all times

Installed apps

simple clock
simple pedometer
charging status
thermometer
launcher
message icons
weather
heart rate monitor
alarms widget
daylight saving
scheduler
health tracking
alarms & timers
astrocalc
tea timer
bluetooth widget
compass
notifications (default)
bootloader
batery level widget (vertical)
messages
sleep log
settings
my location
message ui
android integration

[ticalc-travis]

I just had this happen to me (Bangle 2, 2v19) after having used Sleep Log for a few months. It occurred immediately after changing the time zone setting (actually, installing Daylight Saving to do it for me). Was fine the previous day, then the next day after the time change, the UI is unreadable just as in the screenshot, apparently permanently. Possible clue?

[bobrippling]

I've had a skim through the code and noticed a width being used in place of a height, I'm not sure it impacts the exact issue here but I've deployed it if you wouldn't mind giving it a go?

@storm64 how does this look to you?

Out of interest, does the issue appear consistently now, or just temporarily after changing the timezone?

[ticalc-travis]

It seems consistent: even after changing the time zone back to its original setting the problem persists. It also persists when viewing past logs, including dates from previous log files before the currently-written one. I'll watch and see if the situation changes once the current log where the time change happened gets rotated out in a few days.

It doesn't appear that #3085 patch improves anything, unfortunately.

Edit: I also tried checking the console when running Sleep Log in the broken state but didn't see any errors or messages reported.

[bobrippling]

Thanks for the update and for trying out the patch even so - in that case the issue will be in the drawing code most likely, just an overlap of two draws. But yes, nice idea, let's confirm if it happens when the rotate-out occurs too

[ticalc-travis]

I haven't had time to investigate further, but a quick confirmation that even after a log rotation the symptoms are still present so far. The data still seems intact and reasonable if I view it from the app launcher, but it's still a mystery why the app UI remains confused so persistently.

[bobrippling]

No worries, thanks for confirming - @storm64 I don't suppose you saw anything like this during development of the app?

[storm64]

I just got my BJ2 up to date with all apps and haven't experienced this bug for now.

Tried to change the timezone manually to trigger the drawing issues, but the app draws as it should.

I might have an idea though: As you change the timezone and a sleeping state change is logged, its timestamp could be before the previous logged timestamp. As I remember the logged timestamps should be correct to UTC, but maybe there is something wrong on this part.

I'll try to have a look into this tomorrow.

[bobrippling]

Ah interesting, like if there's a shift back in time perhaps?

[ticalc-travis]

In my case, the local time did shift back an hour upon DST changes. Does the app use UTC internally? I wonder if it could cause problems if by some chance the internal system date/time got changed in an unexpected (i.e., non-monotonic) manner by some means and an incorrect stamp got appended in the log. It seems that would be hairy indeed to deal with.

[storm64]

The internal timestamps are all based on UTC as a timestamp is calculated from ´Date.now()´.

But I don't prevent non-monotonic system time changes as @ticalc-travis predicted.
For now I'm testing with my second BJ2 what might happen on a back shift in time.