Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use self-hosted builders (ESPTOOL-882) #992

Closed
floitsch opened this issue Jul 8, 2024 · 3 comments
Closed

Don't use self-hosted builders (ESPTOOL-882) #992

floitsch opened this issue Jul 8, 2024 · 3 comments

Comments

@floitsch
Copy link

floitsch commented Jul 8, 2024

Is your feature request related to a problem?

The GitHub actions use a self-hosted builder which makes forking the repository harder.

Describe the solution you'd like

You could run the build-steps on GitHub runners in a virtual machine.

Our implementation is here: https://github.com/toitlang/esptool/blob/b2d74c9958b1e6e858b655fbc1b6e28d3b3ca9be/.github/workflows/build.yml

The biggest disadvantage is that the building is much slower.

Describe alternatives you've considered

No response

Additional context

No response

@github-actions github-actions bot changed the title Don't use self-hosted builders Don't use self-hosted builders (ESPTOOL-882) Jul 8, 2024
@radimkarnis
Copy link
Collaborator

Hi @floitsch,
thanks for the request and pointers to your implementation!

I agree forking the repo should be easier. We will look into this!

@floitsch
Copy link
Author

floitsch commented Jul 23, 2024

I just noticed that the linked build.yml script had an LGPL license. This is now changed to BSD-0: https://github.com/toitlang/esptool/blob/b2d74c9958b1e6e858b655fbc1b6e28d3b3ca9be/.github/workflows/build.yml

@FlorianHeigl
Copy link

FlorianHeigl commented Sep 6, 2024

it would make more sense if you'd title this "also allow running on github builders".
a project should be able to chose its infra as the project seems fit, and should be free to use the platforms' features as they seem fit.
(they should also document how to get it to a ci-buildable/forkable state to avoid shooting their own leg)
it sucks as much as it is that the build instructions boil down to 'disect the github ci files'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants