-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes compilation with -save-temps flag (IDFGH-12615) #13613
base: master
Are you sure you want to change the base?
Conversation
👋 Hello denizzzka, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@denizzzka Thanks for the PR, I think we can accept both changes in one branch (i.e. this PR). Could you please update the commit messages as suggested above by the checker, and click through the CLA? |
fa5a517
to
209f2cb
Compare
209f2cb
to
1a38852
Compare
1a38852
to
4d83e2d
Compare
e6dabd7
to
4183043
Compare
Please pay attention to this PR |
(still relevant) |
Project's root
CMakeLists.txt
:If try to compile with
-save-temps
and with:it causes error:
$ idf.py build lib
[...]
components/spiffs/spiffs/src/spiffs_nucleus.c: In function 'spiffs_populate_ix_map_v':
components/spiffs/spiffs/src/spiffs_nucleus.c:682:348: error: self-comparison always evaluates to false [-Werror=tautological-compare]
This PR fixes compilation for such case
Depends from #13612