Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compilation with -save-temps flag (IDFGH-12615) #13613

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Apr 15, 2024

Project's root CMakeLists.txt:

cmake_minimum_required(VERSION 3.16)

# Preserve *.i files
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -save-temps")

include($ENV{IDF_PATH}/tools/cmake/project.cmake)
project(mcu_software)

If try to compile with -save-temps and with:

CONFIG_COMPILER_DISABLE_GCC12_WARNINGS=y
CONFIG_COMPILER_DISABLE_GCC13_WARNINGS=y

it causes error:
$ idf.py build lib
[...]
components/spiffs/spiffs/src/spiffs_nucleus.c: In function 'spiffs_populate_ix_map_v':
components/spiffs/spiffs/src/spiffs_nucleus.c:682:348: error: self-comparison always evaluates to false [-Werror=tautological-compare]

This PR fixes compilation for such case

Depends from #13612

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Apr 15, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello denizzzka, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 4183043

@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 15, 2024
@github-actions github-actions bot changed the title Fixes compilation with -save-temps flag Fixes compilation with -save-temps flag (IDFGH-12615) Apr 15, 2024
@igrr
Copy link
Member

igrr commented Apr 15, 2024

@denizzzka Thanks for the PR, I think we can accept both changes in one branch (i.e. this PR). Could you please update the commit messages as suggested above by the checker, and click through the CLA?

@denizzzka denizzzka force-pushed the save-temps_compilation_fix branch from fa5a517 to 209f2cb Compare April 15, 2024 15:57
@denizzzka denizzzka force-pushed the save-temps_compilation_fix branch 2 times, most recently from e6dabd7 to 4183043 Compare April 19, 2024 13:19
@denizzzka
Copy link
Contributor Author

Please pay attention to this PR

@denizzzka
Copy link
Contributor Author

(still relevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants