Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pypi_release): Update distribution build process #48

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

radimkarnis
Copy link
Collaborator

Change the distribution building process to use build instead of setuptools:

  • The python -m build method is recommended
  • The tar step is problematic (see the recent build failure preventing a PyPI release). This gets rid of that step
  • A wheel is built and uploaded as well instead of just the source

Tests:

@hfudev
Copy link
Member

hfudev commented Sep 4, 2024

LGTM!

Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@radimkarnis radimkarnis merged commit 1c6a15a into espressif:master Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants