reserve the String Length in urlDecode to avoid String Reallocations

Lan-Hekary · Lan-Hekary · commit 8c1074eb7c29 · 2023-10-18T15:38:33.000Z
diff --git a/libraries/ESP8266WebServer/src/Parsing-impl.h b/libraries/ESP8266WebServer/src/Parsing-impl.h
@@ -520,7 +520,7 @@ String ESP8266WebServerTemplate<ServerType>::urlDecode(const String& text)
   char temp[] = "0x00";
   unsigned int len = text.length();
   unsigned int i = 0;
-  decoded.reserve(len);
+  decoded.reserve(len - (std::count(text.begin(), text.end(), '%') * 2 ));
   while (i < len)
   {
     char decodedChar;

Original file line number	Diff line number	Diff line change
`@@ -520,7 +520,7 @@ String ESP8266WebServerTemplate<ServerType>::urlDecode(const String& text)`
`520`	`520`	`char temp[] = "0x00";`
`521`	`521`	`unsigned int len = text.length();`
`522`	`522`	`unsigned int i = 0;`
`523`		`- decoded.reserve(len);`
	`523`	`+ decoded.reserve(len - (std::count(text.begin(), text.end(), '%') * 2 ));`
`524`	`524`	`while (i < len)`
`525`	`525`	`{`
`526`	`526`	`char decodedChar;`