Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reporting of ESMPy test failures in summary #95

Open
billsacks opened this issue Apr 25, 2024 · 1 comment
Open

Incorrect reporting of ESMPy test failures in summary #95

billsacks opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@billsacks
Copy link
Member

When there are failures in some ESMPy tests, at least under some conditions, the summary gives:

esmpy tests:		PASS 0 FAIL 0

The test results page then shows up as green (as if everything passed) when in fact nothing passed.

I have seen this behavior when:

  1. The ESMPy testing crashes early and so nothing runs at all (e.g., due to missing python packages)
  2. The ESMPy testing runs but there is a failed test (e.g., seen in https://github.com/esmf-org/esmf-test-artifacts/tree/964fdf924eb56a17259ac664a6844607a958bfc6/v8.6.1/gfortranclang/12.2.0_14.0.0/O/openmpi/4.1.4)

The issue in both cases seems to be that we don't get a line like this:

{"created": 1713902603.392947, "duration": 260.6280379295349, "exitcode": 0, "root": "/Users/sacks/projects/scratch/esmf-testing/gfortranclang_12.2.0_14.0.0_openmpi_g_develop/esmf/src/addon/esmpy", "environment": {}, "summary": {"passed": 118, "skipped": 4, "xfailed": 8, "xpassed": 1, "total": 131, "collected": 131}}

In case (2), we do get the results in a different format:

= 118 passed, 4 skipped, 8 xfailed, 1 xpassed, 15 warnings in 260.64s (0:04:20) =

but that's not the format picked up by the ESMPy test result parsing in collect_artifacts.py. (When all tests pass, that different format appears first, and then there's a final line that starts with {"created":.)

A different but related issue (but with a different cause) is: when an ESMPy test fails with a given processor count, the other processor counts aren't run. Probably we should run all of the processor counts even if there are failed tests. (That's probably an issue in the ESMPy test scripts themselves, not in this repository, but I haven't dug into it.)

@billsacks billsacks added the bug Something isn't working label Apr 25, 2024
@billsacks billsacks self-assigned this Apr 25, 2024
@billsacks
Copy link
Member Author

@theurich suggests that it might be an issue that should be fixed in the test summarizer: if we see any 0/0 results, we should get a yellow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant