Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "make install" to the build phase instead of the test phase #83

Open
rsdunlapiv opened this issue Sep 15, 2022 · 1 comment
Open
Labels
improve implementation Is working, but could be implemented better.

Comments

@rsdunlapiv
Copy link
Contributor

The argument for this is that the make install command can reveal linking problems that are more closely associated with the build than running the test suite.

@theurich
Copy link
Member

Having "make install" as part of build does make sense. Another way to test linking issues during build would be to add the "make build_apps" target. I am not sure we are testing this target explicitly anywhere right now. It is indirectly tested during "make install", so that does cover it.
I guess an option would be to add "make build_apps" to the build phase, and keep "make install" part of the test phase. Both targets would identify linking issues.

@theurich theurich added the improve implementation Is working, but could be implemented better. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve implementation Is working, but could be implemented better.
Projects
None yet
Development

No branches or pull requests

2 participants