From 10ea5ed9b07968f391c2c8c847cb3eeec9182c2f Mon Sep 17 00:00:00 2001 From: Elizabeth Santorella Date: Thu, 24 Oct 2024 05:34:12 -0700 Subject: [PATCH] Get rid of BotorchTestProblemRunner Summary: It's redundant as per previous diff. Differential Revision: D63722334 --- ax/benchmark/runners/botorch_test.py | 3 --- ax/storage/tests/test_registry_bundle.py | 6 +++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/ax/benchmark/runners/botorch_test.py b/ax/benchmark/runners/botorch_test.py index 8efefc9fc95..a1a96e08147 100644 --- a/ax/benchmark/runners/botorch_test.py +++ b/ax/benchmark/runners/botorch_test.py @@ -207,6 +207,3 @@ def get_Y_true(self, params: Mapping[str, TParamValue]) -> Tensor: dim=-1, ) return Y_true - - -BotorchTestProblemRunner = ParamBasedTestProblemRunner diff --git a/ax/storage/tests/test_registry_bundle.py b/ax/storage/tests/test_registry_bundle.py index b371f4a2002..4add5eb266b 100644 --- a/ax/storage/tests/test_registry_bundle.py +++ b/ax/storage/tests/test_registry_bundle.py @@ -6,7 +6,7 @@ # pyre-strict from ax.benchmark.benchmark_metric import BenchmarkMetric -from ax.benchmark.runners.botorch_test import BotorchTestProblemRunner +from ax.benchmark.runners.botorch_test import ParamBasedTestProblemRunner from ax.metrics.branin import BraninMetric from ax.runners.synthetic import SyntheticRunner from ax.storage.registry_bundle import RegistryBundle @@ -26,7 +26,7 @@ def test_from_registry_bundles(self) -> None: right = RegistryBundle( metric_clss={BenchmarkMetric: None}, - runner_clss={BotorchTestProblemRunner: None}, + runner_clss={ParamBasedTestProblemRunner: None}, json_encoder_registry={}, json_class_encoder_registry={}, json_decoder_registry={}, @@ -41,4 +41,4 @@ def test_from_registry_bundles(self) -> None: self.assertIn(BraninMetric, combined.encoder_registry) self.assertIn(SyntheticRunner, combined.encoder_registry) self.assertIn(BenchmarkMetric, combined.encoder_registry) - self.assertIn(BotorchTestProblemRunner, combined.encoder_registry) + self.assertIn(ParamBasedTestProblemRunner, combined.encoder_registry)