object_store: retry on response decoding errors

erratic-pattern · erratic-pattern · commit ffa3a4b25a85 · 2024-10-06T16:54:26.000-04:00
Closes https://github.com/apache/arrow-rs/issues/6287 This PR includes `reqwest::Error::Decode` as an error case to retry on, which can occur when a server drops a connection in the middle of sending the response body.
diff --git a/object_store/src/client/retry.rs b/object_store/src/client/retry.rs
@@ -312,6 +312,7 @@ impl RetryableRequest {
                     let mut do_retry = false;
                     if e.is_connect()
                         || e.is_body()
+                        || e.is_decode()
                         || (e.is_request() && !e.is_timeout())
                         || (is_idempotent && e.is_timeout())
                     {

Original file line number	Diff line number	Diff line change
`@@ -312,6 +312,7 @@ impl RetryableRequest {`
`312`	`312`	`let mut do_retry = false;`
`313`	`313`	`if e.is_connect()`
`314`	`314`	`\|\| e.is_body()`
	`315`	`+ \|\| e.is_decode()`
`315`	`316`	`\|\| (e.is_request() && !e.is_timeout())`
`316`	`317`	`\|\| (is_idempotent && e.is_timeout())`
`317`	`318`	`{`