Skip to content

Commit a850e9b

Browse files
use Debug impl for generic Reqwest errors to provide more info
see https://github.com/apache/arrow-rs/issues/6377 This should help in the interim to identify specific causes of, sometimes confusing, network related errors. I think this change should be temporary until we can find a better way to improve error messages.
1 parent 3293a8c commit a850e9b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

object_store/src/client/retry.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ pub enum Error {
3939
body: Option<String>,
4040
},
4141

42-
#[snafu(display("Error after {retries} retries in {elapsed:?}, max_retries:{max_retries}, retry_timeout:{retry_timeout:?}, source:{source}"))]
42+
#[snafu(display("Error after {retries} retries in {elapsed:?}, max_retries:{max_retries}, retry_timeout:{retry_timeout:?}, source:{source:?}"))]
4343
Reqwest {
4444
retries: usize,
4545
max_retries: usize,
@@ -174,7 +174,6 @@ impl Default for RetryConfig {
174174
backoff: Default::default(),
175175
max_retries: 10,
176176
retry_timeout: Duration::from_secs(3 * 60),
177-
}
178177
}
179178
}
180179

object_store/src/http/client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ enum Error {
4040
#[snafu(display("Request error: {}", source))]
4141
Request { source: retry::Error },
4242

43-
#[snafu(display("Request error: {}", source))]
43+
#[snafu(display("Request error: {:?}", source))]
4444
Reqwest { source: reqwest::Error },
4545

4646
#[snafu(display("Range request not supported by {}", href))]

0 commit comments

Comments
 (0)