Action never failed even if error level issues are detected & fail_on_error is set to true #103
Comments
|
@jdkato any idea? |
|
Seems like it may be a reviewdog issue, and not vale since it's a reviewdog option. If I'm not wrong, you can close this issue. I posted my workaround in the reviewdog issue reviewdog/reviewdog#1408 |
fharper
added a commit
to fharper/speakerkit
that referenced
this issue
Aug 23, 2023
the 'fail_on_error' option of reviewdog didn't work. See errata-ai/vale-action#103
fharper
added a commit
to konstructio/kubefirst-docs
that referenced
this issue
Aug 23, 2023
the 'fail_on_error' option of reviewdog didn't work. See errata-ai/vale-action#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have the level set to error for my custom vocab, and substitution. When running the GitHub Action, vale report the issues with the proper error level. I also have
fail_on_errorset to true. No matter these, the action always succeed, and never fail. Here's the .vale.ini for reference.I assume I either miss something, didn't use the argument properly or it's a bug. Any idea what is happening here?
The text was updated successfully, but these errors were encountered: