Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencia reportlab necessaria? #9

Open
rvalyi opened this issue Apr 14, 2021 · 1 comment
Open

dependencia reportlab necessaria? #9

rvalyi opened this issue Apr 14, 2021 · 1 comment

Comments

@rvalyi
Copy link
Member

rvalyi commented Apr 14, 2021

Hoje a dependencia com reportlab esta usada apenas pro código de barra da chave da NFE no DANFe:

imagem = createBarcodeDrawing('Code128', value=chave,

Sera se a gente realmente precisa do reportab todo para isso?
Tem essa lib por examplo https://github.com/WhyNotHugo/python-barcode que lida com code 128 tb.

Nao è code 128 (nao sei se precisa), mas o Odoo tb faz isso de forma bem simples:
https://github.com/odoo/odoo/blob/12.0/odoo/addons/base/models/ir_qweb_fields.py#L632

La no Odoo é bom a gente pensar tb nos tests, puxar a instalaçao do reportlab a cada teste é meio pesado. No caso, usando a imagem Docker da CampToCamp, a gente bateu a cabeça porque a gente tava com uma versao anterior do reportlab que nao tinha esse recurso ai dava pau porque aqui nao tinha versao 3.5 mini no setrup,py...

cc @renatonlima @marcelsavegnago @mileo

@rvalyi
Copy link
Member Author

rvalyi commented Apr 14, 2021

update: ver tb #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant