Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coherence in JT Algorithm Lecture Notes #188

Open
manonromain opened this issue Feb 6, 2020 · 0 comments
Open

Coherence in JT Algorithm Lecture Notes #188

manonromain opened this issue Feb 6, 2020 · 0 comments

Comments

@manonromain
Copy link

Hi! In the Junction Tree Algorithm Lecture Notes, I noted some inconsistencies w.r.t. factor graphs. In - that order, I quote:

  • First: "Sum-product message passing can also be applied to factor trees with a slight modification. Recall that a factor graph is a bipartite graph with edges going between variables and factors, with an edge signifying a factor depends on a variable." but factor trees are not mentioned before in the lecture notes.
  • Later, note 5. : "Arbitrary potentials can be handled using an algorithm called LBP on factor graphs. We will include this material at some point in the future."

Reading the notes and understanding what factor trees/graphs is doable, but the phrasing/order is confusing. I'll try submitting a pull request later in the quarter.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant