Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Torrent) Downloader connections after sync is complete? #6876

Closed
mondsen opened this issue Feb 14, 2023 · 15 comments
Closed

(Torrent) Downloader connections after sync is complete? #6876

mondsen opened this issue Feb 14, 2023 · 15 comments
Labels
duplicate This issue or pull request already exists

Comments

@mondsen
Copy link

mondsen commented Feb 14, 2023

I would have used the Discord option as stated in the template for "Ask a question" but the link is not working. Therefore I ask the question here:

Is the downloader after the inital staged sync still required?

If not, and that would be my guess, why are there so many DNS queries for torrent trackers (see this post #5145)? For me it would only make sense to have the downloader active and query the trackers if it is still in use. Is this really the case? If not maybe this could result in an improvement to disable the downloader after sync?

@AskAlexSharov
Copy link
Collaborator

No free cheese. You can download data only because other members of network (synced) seeding it for you. And you will seed for others.

Snapshots storing real useful data (old blocks) - so, seeding them means same as “seeding old blocks” by p2p protocol.

@mondsen
Copy link
Author

mondsen commented Feb 15, 2023

Thanks for clarification! 🙏 Maybe a thing to improve is documentation? I was really wondering about the excessive DNS queries for torrent trackers. I can make a proposal and open a PR if you like.

@AskAlexSharov
Copy link
Collaborator

There is ~7 hostnames of trackers - don’t know why need much dns requests

@mondsen
Copy link
Author

mondsen commented Feb 15, 2023

These are the queries from the first 8 hours of today:
grafik
For me that is a lot. At least know I know why. There are sometimes over 40 DNS requests per second...

@AskAlexSharov
Copy link
Collaborator

Seems not looks as coincidence: 30K / 8h / 60m / 60sec = 1
:-)

@anacrolix
Copy link

That is concerning! I think Go doesn't do any DNS caching of its own, it's normal to provide this at the system level. What OS are you running on?

I did break this precedent for anacrolix/dht in https://github.com/anacrolix/dht/blob/master/dns.go. I think it would be okay to use a similar strategy in anacrolix/torrent for trackers. I'm curious if anyone has more insight into how this is normally handled (like system level should be fine).

@github-actions
Copy link

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
@luncht1me
Copy link

luncht1me commented May 11, 2023

I'd like to be able to limit these requests. My ISP doesn't like it and my modem gets bogged down after a few days of seeding. I've tried reducing with --torrent.conns.perfile, --torrent.upload.rate, --maxpeers and --sentry.drop-useless-peers but I'm still getting some bad internet issues over time while syncing.

Any way to reduce the network impact? So far for me the only solution to restore my network is to completely power down my modem and reset it. When can we have --torrent.maxpeers enabled? I feel this may help me as it's mostly from a large number of connections and dns hits that pwns me.

I'd love to keep seeding cause it's important for Erigon users. But I may simply have to resort to --no-downloader flag for the time being.

@anacrolix
Copy link

Please open or reference an issue at anacrolix/torrent for this!

@AskAlexSharov
Copy link
Collaborator

@luncht1me do you see same problem if re-compile erigon with netgo tag?
Example: go build -tags=netgo,nosqlite,noboltdb -o ./build/bin/erigon ./cmd/erigon

For more info see: golang/go#30310

@AskAlexSharov AskAlexSharov reopened this May 12, 2023
@github-actions github-actions bot removed the Stale label May 13, 2023
@github-actions
Copy link

This issue is stale because it has been open for 40 days with no activity. Remove stale label or comment, or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 1, 2023
@victorelec14
Copy link

i have the same problem, more as 20 Queries per second and 460,000 queries per day #9330

@battlmonstr battlmonstr added duplicate This issue or pull request already exists and removed Stale labels Jun 10, 2024
@battlmonstr
Copy link
Contributor

duplicate of #5145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

6 participants