Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with py37 #153

Open
jph00 opened this issue Dec 17, 2019 · 1 comment
Open

Problems with py37 #153

jph00 opened this issue Dec 17, 2019 · 1 comment

Comments

@jph00
Copy link

jph00 commented Dec 17, 2019

With the new py version restriction, pip will now as a result install dataclasses 0.6 if install is attempted on py37, since this is the last available version that satisfies this constraint. This might be a problem, since it shadows the builtin version. The reason this comes up is packaging a module the depends on dataclasses, but only python>=3.6, becomes tricky to do correctly. I believe the correct line is:

dataclasses>='0.7';python_version<'3.7'

Ideally, I think it would be nice if this dataclasses module simply returns the builtin python module if it's available (although I'm not sure how to implement that in practice!) If this isn't possible/desirable, perhaps you could add to the readme/docs something about how to install only on python<3.7 (e.g. using the above line)?

@sethmlarson
Copy link

Another idea would be to yank all releases before 0.7. That way pip doesn't try to resolve any of these versions unless specifically requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants