Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer overflow when adding ssh key #179

Open
mercury00 opened this issue Feb 5, 2013 · 0 comments
Open

buffer overflow when adding ssh key #179

mercury00 opened this issue Feb 5, 2013 · 0 comments

Comments

@mercury00
Copy link

Plugin is working fine for many repos, and many users (great plugin btw!).

However, I have at least one user that I continuously get this error in the logs:

remote: buffer_get_ret: trying to get more bytes 257 than in buffer 251 remote: buffer_get_string_ret: buffer_get failed remote: buffer_get_bignum2_ret: invalid bignum remote: key_from_blob: can't read rsa key remote: key_read: key_from_blob {ssh key deleted from post} failed remote: line 1 too long: ssh-rsa {the deleted key}... remote: FATAL: fingerprinting failed for 'keydir/{some users ssh key}.pub' To gitolite@{myhost}:gitolite-admin.git 282256f..3715e29 master -> master

It seems like the buffer is too small for the rsa key. Is this so? Would appreciate either a patch to increase the buffer size to valid rsa key lengths or some input on where I should look in the current code to change the buffer size so I can verify for myself if this is in fact the problem and not something else. By the way, in /keydir/ the rsa key is showing fine, it's being imported there at least and is the same as on the user's computer. It doesn't get included in .ssh/authorized keys on the gitolite user like all the other keys though, so the user is unable to checkout code, etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant