Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.worker.js files are not supported, but generated by CTS upstream #120

Closed
ErichDonGubler opened this issue Jun 24, 2024 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ErichDonGubler
Copy link
Collaborator

Upstream WebGPU CTS currently generates variants of WPT test manifests that run in dedicated worker contexts in a webworker top-level directory (i.e., tests/webworker/api/operation/…/requestAdapter.worker.js. These files are "converted" to HTML test by wptrunner and reported as *.worker.html entries in WPT execution reports.

When moz-webgpu-cts encounters these reports, it assumes that the corresponding metadata path should simply add an ini file extension to the reported HTML URL path, viz., meta/webworkers/api/operation/…/requestAdapter.worker.html.ini, rather than …/requestAdapter.worker.js.ini. These incorrectly placed metadata files are subsequently (rightfully) ignored by wptrunner, because they're not in the right place.

@ErichDonGubler ErichDonGubler added the bug Something isn't working label Jun 24, 2024
@ErichDonGubler ErichDonGubler self-assigned this Jun 24, 2024
@ErichDonGubler
Copy link
Collaborator Author

Solution space I see:

  1. By checking for a .worker suffix in the reported test's basename, we could "just" assume that anything ending in *.worker.html actually corresponds to a *.worker.js manifest. Support *.worker.js metadata and reports #119 does this, and it seems like a relatively easy change to make (though it will make the TestPath model significantly more complicated).
  2. We could build a registry of all test manifest files (i.e., tests/**), and then refer to it when we check where a reported test entry could have been specified. This creates more data dependency in moz-webgpu-cts, which I'm wary of. It also seems a lot more I/O and data than I think are necessary.

@ErichDonGubler
Copy link
Collaborator Author

Resolved by gpuweb/cts#3835; it turns out, WebGPU CTS was unintentionally overlapping its naming convention of files with WPT's. 😅

I'm migrating the scope of "once we have worker.js tests, we'll need support" over to #122. Otherwise, this is done!

@github-project-automation github-project-automation bot moved this from In Progress to Done in WebGPU for Firefox Jul 8, 2024
@ErichDonGubler ErichDonGubler changed the title *.worker.js files are not supported, but generated by CTS upstream Generated *.worker.js files are not valid WPT tests, but included in npm run wpt's output Aug 20, 2024
@ErichDonGubler ErichDonGubler changed the title Generated *.worker.js files are not valid WPT tests, but included in npm run wpt's output *.worker.js files are not supported, but generated by CTS upstream Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant