Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing Buffer from node code, replace with native array type #538

Open
ericblade opened this issue Apr 30, 2024 · 3 comments
Open

Comments

@ericblade
Copy link
Owner

More info: https://sindresorhus.com/blog/goodbye-nodejs-buffer

Also would provide a better fix for: #509

The current fix is just to install the type, because it doesn't matter... but it could matter in user code.

@yogeshgadge
Copy link

added PR #539

@yogeshgadge
Copy link

side observations: root tsconfig.json has types ["mocha", "node"]
probably consider tsconfig.test.json for the mocha tests inside src/

@ericblade
Copy link
Owner Author

good idea. there's been some recent upgrades to typescript's handling of nested tsconfig files, too, an update to current ts is probably a good idea too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants