Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove special fix for plonk verifiers #101

Open
numtel opened this issue Oct 18, 2024 · 2 comments
Open

chore: Remove special fix for plonk verifiers #101

numtel opened this issue Oct 18, 2024 · 2 comments
Assignees

Comments

@numtel
Copy link
Contributor

numtel commented Oct 18, 2024

iden3/snarkjs#464 was merged and is now included in snarkjs 0.7.5 so we can remove the special case for plonk verifiers:

https://github.com/erhant/circomkit/blob/main/tests/circomkit.test.ts#L97

The way snarkjs is set as a peerDependency for 0.7.x, it would need to be updated to ^0.7.5 too I would imagine though

@erhant
Copy link
Owner

erhant commented Oct 25, 2024

good point!

The way snarkjs is set as a peerDependency for 0.7.x, it would need to be updated to ^0.7.5 too I would imagine though
indeed

will include this for some minor version update soon, but lets wait a bit until SnarkJS gets updated around the place 👍🏻

@erhant
Copy link
Owner

erhant commented Oct 25, 2024

the existing fix does not break with the fixed snarksj version though right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants