From 257e3bd22fce7e876bc3225776e67e607e4bc2ae Mon Sep 17 00:00:00 2001 From: FWJimmo <160784174+FWJimmo@users.noreply.github.com> Date: Thu, 7 Mar 2024 12:49:26 -0500 Subject: [PATCH 1/2] subs array now handles empty array sets properly If the subs array set is empty, don't acknowledge the subs child and create unnecessary HTML. --- comboTreePlugin.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/comboTreePlugin.js b/comboTreePlugin.js index 6cb4bad..657f585 100644 --- a/comboTreePlugin.js +++ b/comboTreePlugin.js @@ -159,7 +159,10 @@ ComboTree.prototype.createSourceItemHTML = function (sourceItem) { let itemHtml = ""; - const isThereSubs = sourceItem.hasOwnProperty("subs"); + let isThereSubs = false; + if (sourceItem.hasOwnProperty("subs")) { + isThereSubs = sourceItem.subs.length > 0; + } const collapse = sourceItem.hasOwnProperty("collapse") ? sourceItem.hasOwnProperty("collapse") : false; From 1e5563dc95813075054cb6470812d3b124d1688f Mon Sep 17 00:00:00 2001 From: FWJimmo <160784174+FWJimmo@users.noreply.github.com> Date: Thu, 7 Mar 2024 14:18:15 -0500 Subject: [PATCH 2/2] swap to ternary Cleanup for ternary instead of expanded if/wasted space. --- comboTreePlugin.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/comboTreePlugin.js b/comboTreePlugin.js index 657f585..90cd9ce 100644 --- a/comboTreePlugin.js +++ b/comboTreePlugin.js @@ -159,10 +159,7 @@ ComboTree.prototype.createSourceItemHTML = function (sourceItem) { let itemHtml = ""; - let isThereSubs = false; - if (sourceItem.hasOwnProperty("subs")) { - isThereSubs = sourceItem.subs.length > 0; - } + let isThereSubs = sourceItem.hasOwnProperty("subs") ? (sourceItem.subs.length > 0) : false; const collapse = sourceItem.hasOwnProperty("collapse") ? sourceItem.hasOwnProperty("collapse") : false;