Skip to content

Commit f1d6a83

Browse files
committed
Add actual bool_flags for the settings
1 parent b1cc266 commit f1d6a83

File tree

4 files changed

+33
-3
lines changed

4 files changed

+33
-3
lines changed

.bazelrc

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
build:clang-tidy --aspects @bazel_clang_tidy//clang_tidy:clang_tidy.bzl%clang_tidy_aspect
2-
build:clang-tidy --output_groups=report
2+
build:clang-tidy --output_groups=report
3+
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_bazel_out_includes_are_system_includes=True
4+
build:clang-tidy --@bazel_clang_tidy//:clang_tidy_virtual_includes_are_system_includes=True

BUILD

+14
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")
2+
13
filegroup(
24
name = "clang_tidy_config_default",
35
srcs = [
@@ -33,3 +35,15 @@ label_flag(
3335
build_setting_default = ":clang_tidy_additional_deps_default",
3436
visibility = ["//visibility:public"],
3537
)
38+
39+
bool_flag(
40+
name = "clang_tidy_bazel_out_includes_are_system_includes",
41+
build_setting_default = False,
42+
visibility = ["//visibility:public"],
43+
)
44+
45+
bool_flag(
46+
name = "clang_tidy_virtual_includes_are_system_includes",
47+
build_setting_default = False,
48+
visibility = ["//visibility:public"],
49+
)

WORKSPACE

+14
Original file line numberDiff line numberDiff line change
@@ -1 +1,15 @@
11
workspace(name = "bazel_clang_tidy")
2+
3+
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
4+
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
5+
6+
maybe(
7+
http_archive,
8+
name = "bazel_skylib",
9+
sha256 = "cd55a062e763b9349921f0f5db8c3933288dc8ba4f76dd9416aac68acee3cb94",
10+
url = "https://github.com/bazelbuild/bazel-skylib/releases/download/1.5.0/bazel-skylib-1.5.0.tar.gz",
11+
)
12+
13+
load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
14+
15+
bazel_skylib_workspace()

clang_tidy/clang_tidy.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,8 @@ clang_tidy_aspect = aspect(
205205
"_clang_tidy_executable": attr.label(default = Label("//:clang_tidy_executable")),
206206
"_clang_tidy_additional_deps": attr.label(default = Label("//:clang_tidy_additional_deps")),
207207
"_clang_tidy_config": attr.label(default = Label("//:clang_tidy_config")),
208-
"_clang_tidy_bazel_out_includes_are_system_includes": attr.bool(default = False),
209-
"_clang_tidy_virtual_includes_are_system_includes": attr.bool(default = False),
208+
"_clang_tidy_bazel_out_includes_are_system_includes": attr.label(default = Label("//:clang_tidy_bazel_out_includes_are_system_includes")),
209+
"_clang_tidy_virtual_includes_are_system_includes": attr.label(default = Label("//:clang_tidy_virtual_includes_are_system_includes")),
210210
},
211211
toolchains = ["@bazel_tools//tools/cpp:toolchain_type"],
212212
)

0 commit comments

Comments
 (0)