New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test scripts exit with success code when build fails #271

Open

fulldecent opened this issue Nov 18, 2019 · 0 comments

Labels

Contributor

fulldecent commented Nov 18, 2019

Build errors should propagate to the test runner so that errors are more visible.

Recommendation: update build (run-ganache-deploy.sh) and test (run-ganache-tests.sh) steps so that errors result in the test suite failing.

References:

https://github.com/erasureprotocol/erasure-protocol/pull/253/checks?check_run_id=301980938

thegostep added the improvement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment