Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724

Closed
nilscb opened this issue Oct 20, 2023 · 0 comments · Fixed by #1737
Closed

Performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724

nilscb opened this issue Oct 20, 2023 · 0 comments · Fixed by #1737
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.

Comments

@nilscb
Copy link
Collaborator

nilscb commented Oct 20, 2023 •
edited
Loading

May be implemented in shader for speed and cleaner code instead of in javascript.
Also this will fix following issue: #1722

  • Grid3DLayer - Done

  • MapLayer - Done

  • TriangleLayer - Done

  • AxesLayer. Not touched as it will not effect performance and add code complexity.

These layers are "off the shelves" and do not have shaders written by us

  • PointsLayer
  • PolylinesLayer
@nilscb nilscb added enhancement New feature or request AspenTech Task owned by AspenTech map-component Issues related to the map component. labels Oct 20, 2023
nilscb added a commit to nilscb/webviz-subsurface-components that referenced this issue Oct 23, 2023
@nilscb
Fix of: Performance: Apply flag "ZIncreasingDownwards" in vertex shad…
0fc3636 
…ers for relevant layers. equinor#1724
@nilscb nilscb mentioned this issue Oct 23, 2023
Merged
w1nklr pushed a commit that referenced this issue Oct 23, 2023
@nilscb
fix: Grid3DLayer should apply flag "ZIncreasingDownwards" for correct…
108b660 
… readout of depth. (#1729)

* Fix of:
- Grid3DLayer should apply flag "ZIncreasingDownwards" for correct readout of depth. #1723

* Partial fix of:
- Performance: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724
hkfb pushed a commit that referenced this issue Oct 23, 2023
@semantic-release-bot
chore(release): 0.4.2 [skip ci]
a43e9b1 
## [0.4.2](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.4.2) (2023-10-23)

### Bug Fixes

* Grid3DLayer should apply flag "ZIncreasingDownwards" for correct readout of depth. ([#1729](#1729)) ([108b660](108b660)), closes [#1723](#1723) [#1724](#1724)
@w1nklr w1nklr mentioned this issue Oct 23, 2023
Merged
w1nklr added a commit that referenced this issue Oct 23, 2023
@nilscb @w1nklr
fix: irrelevant X, Y, Z readout for map layer (#1731)
704334a 
- fix incorrect X, Y and Z coordinates returned by the mouse event for the map layer #1654 
- performance: handle ZIncreasingDownwards by the shader for map layer #1724 

---------

Co-authored-by: t0oF-azpn <[email protected]>
hkfb pushed a commit that referenced this issue Oct 23, 2023
@semantic-release-bot
chore(release): 0.4.3 [skip ci]
4b1e844 
## [0.4.3](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.4.3) (2023-10-23)

### Bug Fixes

* irrelevant X, Y, Z readout for map layer ([#1731](#1731)) ([704334a](704334a)), closes [#1654](#1654) [#1724](#1724)
nilscb added a commit to nilscb/webviz-subsurface-components that referenced this issue Oct 25, 2023
@nilscb
performance: Apply flag "ZIncreasingDownwards" in vertex shaders for …
b2248f1 
…relevant layers. equinor#1724
@nilscb nilscb mentioned this issue Oct 25, 2023
Merged
@nilscb nilscb linked a pull request Oct 25, 2023 that will close this issue
perf: Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724 #1737
Merged
nilscb added a commit that referenced this issue Oct 26, 2023
@nilscb
performance: Apply flag "ZIncreasingDownwards" in vertex shaders for …
1fbfa23 
…relevant layers. #1724 (#1737)
nilscb added a commit to nilscb/webviz-subsurface-components that referenced this issue Oct 27, 2023
@nilscb
performance: Apply flag "ZIncreasingDownwards" in vertex shaders MapL…
528f407 
…ayer.

  - This is related to earlier commit. MapLayer was missing
  -  Earlier commit: performance:  Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. equinor#1724 (equinor#1737)
@nilscb nilscb mentioned this issue Oct 27, 2023
Merged
w1nklr pushed a commit that referenced this issue Oct 27, 2023
@nilscb
perf: Apply flag "ZIncreasingDownwards" in vertex shaders MapLayer. (#…
ed85f7f 
…1741)

- This is related to earlier commit. MapLayer was missing
- Earlier commit: performance:  Apply flag "ZIncreasingDownwards" in vertex shaders for relevant layers. #1724 (#1737)
hkfb pushed a commit that referenced this issue Oct 27, 2023
@semantic-release-bot
chore(release): 0.5.4 [skip ci]
821b6bd 
## [0.5.4](https://github.com/equinor/webviz-subsurface-components/compare/[email protected]@0.5.4) (2023-10-27)

### Performance Improvements

*  Apply flag "ZIncreasingDownwards" in vertex shaders MapLayer. ([#1741](#1741)) ([ed85f7f](ed85f7f)), closes [#1724](#1724) [#1737](#1737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AspenTech Task owned by AspenTech enhancement New feature or request map-component Issues related to the map component.
Projects
None yet
Milestone
No milestone
1 participant
@nilscb