From 187525871d071e58a6529129774fec03aae9d1c5 Mon Sep 17 00:00:00 2001 From: Nils Christian Bonnevie Date: Fri, 3 Nov 2023 09:46:21 +0100 Subject: [PATCH] Code comment fixes --- .github/workflows/smoke_test.yml | 10 +++--- .../settings/LayerSettingsButton.stories.tsx | 36 ------------------- 2 files changed, 6 insertions(+), 40 deletions(-) delete mode 100644 typescript/packages/subsurface-viewer/src/storybook/components/settings/LayerSettingsButton.stories.tsx diff --git a/.github/workflows/smoke_test.yml b/.github/workflows/smoke_test.yml index 559da8118..27558394d 100644 --- a/.github/workflows/smoke_test.yml +++ b/.github/workflows/smoke_test.yml @@ -2,13 +2,15 @@ name: Smoke Tests on: push: - branches: [master] + branches: + - master pull_request: - branches: [master] + branches: + - master defaults: run: - working-directory: typescript + working-directory: ./typescript jobs: test: name: Smoke Tests @@ -20,7 +22,7 @@ jobs: - name: Use Node.js uses: actions/setup-node@v3 with: - node-version: '16' + node-version: '>= 18' - name: Install dependencies run: npm ci diff --git a/typescript/packages/subsurface-viewer/src/storybook/components/settings/LayerSettingsButton.stories.tsx b/typescript/packages/subsurface-viewer/src/storybook/components/settings/LayerSettingsButton.stories.tsx deleted file mode 100644 index 8667cddb3..000000000 --- a/typescript/packages/subsurface-viewer/src/storybook/components/settings/LayerSettingsButton.stories.tsx +++ /dev/null @@ -1,36 +0,0 @@ -import React from "react"; -import LayerSettingsButton from "../../../components/settings/LayerSettingsButton"; - -export default { - component: LayerSettingsButton, - title: "SubsurfaceViewer/Components/Settings/LayerSettingsButton", -}; - -// Note: Disabled for now will be fixed later. Missing redux context. - -// const Template = (args) => { -// return ; -// }; - -// export const DrawingSettings = Template.bind({}); -// DrawingSettings.args = { -// layer: { -// name: "Drawing", -// "@@type": "DrawingLayer", -// id: "drawing-layer", -// visible: true, -// mode: "drawLineString", -// }, -// }; - -// export const WellsSettings = Template.bind({}); -// WellsSettings.args = { -// layer: { -// name: "Wells", -// "@@type": "WellsLayer", -// id: "wells-layer", -// opacity: 1, -// pointRadiusScale: 8, -// visible: true, -// }, -// };