-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assumptions regarding ERT environment variables are wrong #605
Comments
Very nicely debugged. I guess this was a trap we had to fall in eventually. Key learning here is that it causes some problems when the
So logic has to be on the absence AND presence of something, I guess, rather than just on the presence of something. |
@tnatt this can be closed? |
Yes, should be fine to close this now. We have yet to set up an ERT integration tests to detect these things, but we have a separate issue for it #588. |
Our assumptions regarding when ERT environment variables are present are wrong
_ERT_EXPERIMENT_ID
_ERT_ENSEMBLE_ID
_ERT_SIMULATION_MODE
_ERT_EXPERIMENT_ID
_ERT_ENSEMBLE_ID
_ERT_SIMULATION_MODE
forward model
_ERT_EXPERIMENT_ID
_ERT_ENSEMBLE_ID
_ERT_SIMULATION_MODE
_ERT_RUNPATH
_ERT_ITERATION_NUMBER
_ERT_REALIZATION_NUMBER
_ERT_RUNPATH
_ERT_ITERATION_NUMBER
_ERT_REALIZATION_NUMBER
Hence these lines in the
FmuProvider
will leave the fmu metadata empty when running a forward model (Note: except for ERT test_run):fmu-dataio/src/fmu/dataio/providers/_fmu.py
Lines 122 to 126 in 6ba4b49
This has gone a bit undetected because:
Good thing is! This will be fixed by the changes introduced in the PR #599, as the logic was refactored there 👍
But we need to:
The text was updated successfully, but these errors were encountered: