Move plot_api #8897
Closed
Move plot_api #8897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
added
the
release-notes:refactor
eivindjahren
force-pushed
the
move_plot_api
branch
from
4af4c84
to
465ca2c
Compare
eivindjahren
force-pushed
the
move_plot_api
branch
3 times, most recently
from
23e82b3
to
d465295
Compare
As plot_api is used by both ert.gui.plottery and ert.gui.tools.plot, its current location causes circular dependency problems. Moving it to ert.gui resolves that problem.
eivindjahren
force-pushed
the
move_plot_api
branch
from
d465295
to
4f1a896
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8897 +/- ##
=======================================
Coverage 91.37% 91.38%
=======================================
Files 344 344
Lines 21119 21118 -1
=======================================
+ Hits 19297 19298 +1
+ Misses 1822 1820 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Replaced by #8900 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
plot_apiis used by bothert.gui.plotteryandert.gui.tools.plot, its current location causes circular dependency problems. Moving it toert.guiresolves that problem.git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable