Exception is never raised in fm_dispatch due to self-kill

[berland]

The os.killpg kills the fm_dispatch process such that the exception e is never raised. If there is a bug in fm_dispatch that triggers an exception, it will not be printed to the terminal. Running fm_dispatch in the runpath only gives you the output Terminated.

ert/src/_ert/forward_model_runner/fm_dispatch.py

Lines 194 to 199 in 68271ad

	try:
	fm_dispatch(sys.argv)
	except Exception as e:
	pgid = os.getpgid(os.getpid())
	os.killpg(pgid, signal.SIGTERM)
	raise e

[jonathan-eq]

I can change it to another signal, and add a signal_handler connected to proc.kill() in forward_model_step.py. How about signal.SIGQUIT? @berland

[berland]

It is dangerous to remove the killpg() call as it ensures every descendant is taken down. What about just printing e and then kill? Add an random exception somewhere in fm_dispatch and check the developer experience.

[jonathan-eq]

But what about the exit code if we only print the exception? Will it default to 0, or will it be set due by SIGKILL?
EDIT: The exit code is not 0 when we SIGKILL, so it should be fine :)