Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin mypy #9996

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Unpin mypy #9996

merged 1 commit into from
Feb 7, 2025

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Feb 6, 2025 •
edited
Loading

Issue
Resolves #9970

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9996 will not alter performance

Comparing larsevj:unpin_mypy (4287218) with main (912dbc8)

Summary

✅ 25 untouched benchmarks

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Feb 6, 2025
@larsevj larsevj marked this pull request as ready for review February 6, 2025 12:45
eivindjahren
eivindjahren reviewed Feb 6, 2025
View reviewed changes
src/ert/plugins/hook_implementations/help_resources.py Outdated
@ert.plugin(name="ert") # type: ignore
def help_links():
@ert.plugin(name="ert")
def help_links(): # type: ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid the # type: ignore by adding -> dict[str, str] instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also changed the inside_str from bool(char) to simply True, char would always be "'" so always True I believe.

eivindjahren
eivindjahren approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question about trying to avoid # type: ignore, otherwise looks good.

@larsevj larsevj merged commit afacbac into equinor:main Feb 7, 2025
27 checks passed
@larsevj larsevj deleted the unpin_mypy branch February 7, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngve-sk yngve-sk yngve-sk approved these changes

@eivindjahren eivindjahren eivindjahren approved these changes

Assignees
No one assigned
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin mypy
3 participants
@larsevj @yngve-sk @eivindjahren