Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: tests/everest/test_math_func.py::test_math_func_advanced #9732

Closed
oyvindeide opened this issue Jan 14, 2025 · 2 comments
Closed

Review: tests/everest/test_math_func.py::test_math_func_advanced #9732

oyvindeide opened this issue Jan 14, 2025 · 2 comments
Assignees
@frode-aarstad

Comments

@oyvindeide
Copy link
Collaborator

This test takes a long time to run, we should see if there is a way we can improve the runtime without compromising the quality of what is being tested.
@oyvindeide oyvindeide added this to SCOUT Jan 14, 2025
@oyvindeide oyvindeide moved this to Todo in SCOUT Jan 14, 2025
@yngve-sk
Copy link
Contributor

yngve-sk commented Jan 27, 2025 •
edited
Loading

With #9763 in we can use a cached example and access the controls/snapshots etc via storage instead of a baserunmodel for some of them

@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Jan 29, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 29, 2025
@frode-aarstad
Copy link
Contributor

After #9763 has been merged this test only takes 1s 🚀

@github-project-automation github-project-automation bot moved this from In Progress to Done in SCOUT Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frode-aarstad frode-aarstad

Labels
None yet
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yngve-sk @frode-aarstad @oyvindeide