Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Stage, Step and Job from ensemble_evaluator._builder #6218

Closed
Tracked by #6270
pinkwah opened this issue Oct 2, 2023 · 2 comments · Fixed by #6313
Closed
Tracked by #6270

Remove Stage, Step and Job from ensemble_evaluator._builder #6218

pinkwah opened this issue Oct 2, 2023 · 2 comments · Fixed by #6313
Assignees
@berland
Labels
maintenance Not a bug now but could be one day, repaying technical debt

Comments

@pinkwah
Copy link
Contributor

pinkwah commented Oct 2, 2023

Job is just a container for ert.config.ext_job.ExtJob, so let Realization contain a list of ExtJobs maybe.

The other parts have no value.
@berland berland self-assigned this Oct 3, 2023
@berland
Copy link
Contributor

berland commented Oct 19, 2023 •
edited
Loading

@berland berland mentioned this issue Oct 19, 2023
Merged
8 tasks
@berland berland reopened this Oct 25, 2023
This was referenced Oct 26, 2023
Merged
Merged
@berland berland added the maintenance Not a bug now but could be one day, repaying technical debt label Oct 27, 2023
This was referenced Nov 2, 2023
Merged
Merged
Closed
@berland berland closed this as completed Nov 7, 2023
@berland
Copy link
Contributor

berland commented Nov 7, 2023

Rougly 600 lines less code from the PRs solving this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berland berland

Labels
maintenance Not a bug now but could be one day, repaying technical debt
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the possibility for multiple Steps in a Realization, remove Stage berland/ert
2 participants
@berland @pinkwah