improve ecl_config script error message

[valentin-krasontovitsch]

Describe the bug
When running some tests (everest), a file is reported as non-executable, which is technically correct, but in fact the file is non-existing. the error message should be improved.

Error message:

File "/lustre1/prog/komodo/2023.04.rc0-py38-rhel7/root/lib64/python3.8/site-packages/ert/shared/share/ert/forward-models/res/script/ecl_config.py", line 45, in __init__
    raise OSError(f"The executable: '{executable}' can not be executed by user")
OSError: The executable: '/prog/ecl/grid/2015.2/bin/linux_x86_64/eclipse.exe' can not be executed by user

Suggested fix: check for missing file in src/ert/shared/share/ert/forward-models/res/script/ecl_config.py around line 45.

[Jehan-h20220012]

Can anyone help me with this issue so that I can raise a PR to close it.

[valentin-krasontovitsch]

what kind of questions do you have, @Jehan-h20220012 ?

[sondreso]

See also: #4241 (Resolving that issue would remove this codepath)

[valentin-krasontovitsch]

i haven't gotten into the details of these things yet - @sondreso , does the issue you link to imply that we want to get rid of the script that this issue wants to improve? : )

[sondreso]

There are essentially two ways of starting the Eclipse simulator in the code today, one code path that interacts with a binary called eclrun (for all versions newer than 2018.2) and another code path that interacts with the binary of the individual releases (versions prior to 2018.2). The error message above comes from the latter. We have confirmation that we don't need to support these older versions in the newest version of ERT, so we can remove this code path altogether.

[valentin-krasontovitsch]

nice! closing in favor of #4241