Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid mapping of license field #34

Open
jesusbagpuss opened this issue Nov 24, 2015 · 3 comments · May be fixed by #46
Open

Invalid mapping of license field #34

jesusbagpuss opened this issue Nov 24, 2015 · 3 comments · May be fixed by #46

Comments

@jesusbagpuss
Copy link
Contributor

From:

rioxx2/cfg/cfg.d/zz_rioxx2.pl

Lines 229 to 239 in 3e029db

$c->{rioxx2}->{license_map} = {
cc_by_nd => "http://creativecommons.org/licenses/by-nd/4.0",
cc_by => "http://creativecommons.org/licenses/by/4.0",
cc_by_nc => "http://creativecommons.org/licenses/by-nc/4.0",
cc_by_nc_nd => "http://creativecommons.org/licenses/by-nc-nd/4.0",
cc_by_nc_sa => "http://creativecommons.org/licenses/by-nd-sa/4.0",
cc_by_sa => "http://creativecommons.org/licenses/by-sa/4.0",
cc_public_domain=> "http://creativecommons.org/publicdomain/zero/1.0/legalcode",
cc_gnu_gpl => "http://www.gnu.org/licenses/gpl.html",
cc_gnu_lgpl => "http://www.gnu.org/licenses/lgpl.html",
};

This maps the EPrints namedset values 'cc_by' etc. to v4 licences.
I don't think this is valid. In the most recent release of EPrints, there are cc_by_4 values that should be mapped. As I understand it, license versions are NOT transmutable.

NB For a while, the labels in EPrints (in the workflow) didn't match the rendered output (one being v2.5, the other v3).
IMO EPrints should be storing the licences as URIs (I may look at creating a Bazaar package that includes all CC licences, and suitable render phrases, and allows something like <field ref="license" options="v4"/> in the workflow).
@jesusbagpuss
Copy link
Contributor Author

Also, there are two licences that aren't covered by the current plugin (see: http://www.rioxx.net/schema/v2.0/rioxx/ali_1_0.html#license_ref or http://rioxx.net/guidelines/RIOXX_Metadata_Guidelines_v_3.0.pdf, page 8):

  • http://www.rioxx.net/licenses/all-rights-reserved
  • http://www.rioxx.net/licenses/under-embargo-all-rights-reserved

Also relates to #26

@jesusbagpuss
Copy link
Contributor Author

EPrints currently ships with:
https://github.com/eprints/eprints/blob/3.3/lib/defaultcfg/namedsets/licenses
(v3 and v4).

Also, this;

rioxx2/cfg/cfg.d/zz_rioxx2.pl

Lines 448 to 458 in 3e029db

$c->{rioxx2_value_license_ref} = sub {
my( $eprint, $document ) = @_;
return undef unless $document;
return undef unless $document->is_set( "license" );
my $license = $document->repository->config( "rioxx2", "license_map", $document->value( "license" ) );
return undef unless $license;
my $start_date = $eprint->value( "date" ) if ( !$eprint->is_set( "date_type" ) || $eprint->value( "date_type" ) eq "published" );
$start_date = $document->value( "date_embargo" ) if $document->is_set( "date_embargo" );
return { license_ref => $license, start_date => $start_date };
};
should be updated to pass-through the value if it an http/s URI.

@fatchild
Copy link

fatchild commented Oct 3, 2022

This is still an issue in 3.4

Pub router contains the correct mapping... https://bazaar.eprints.org/1127/1/epm/pubrouter_rioxx_importer/cfg/cfg.d/zzz_pubrouter_rioxx_importer.pl

$c->{rioxx2}->{license_map} = {
        cc_by_nd        => "http://creativecommons.org/licenses/by-nd/3.0",
        cc_by           => "http://creativecommons.org/licenses/by/3.0",
        cc_by_nc        => "http://creativecommons.org/licenses/by-nc/3.0",
        cc_by_nc_nd     => "http://creativecommons.org/licenses/by-nc-nd/3.0",
        cc_by_nc_sa     => "http://creativecommons.org/licenses/by-nd-sa/3.0",
        cc_by_sa        => "http://creativecommons.org/licenses/by-sa/3.0",
        cc_public_domain=> "http://creativecommons.org/publicdomain/zero/1.0/legalcode",
        cc_gnu_gpl      => "http://www.gnu.org/licenses/gpl.html",
        cc_gnu_lgpl     => "http://www.gnu.org/licenses/lgpl.html",
	cc_by_nd_4      => "http://creativecommons.org/licenses/by-nd/4.0",
        cc_by_4         => "http://creativecommons.org/licenses/by/4.0",
        cc_by_nc_4      => "http://creativecommons.org/licenses/by-nc/4.0",
        cc_by_nc_nd_4   => "http://creativecommons.org/licenses/by-nc-nd/4.0",
        cc_by_nc_sa_4   => "http://creativecommons.org/licenses/by-nd-sa/4.0",
        cc_by_sa_4      => "http://creativecommons.org/licenses/by-sa/4.0",
};

@fatchild fatchild linked a pull request Oct 3, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mapping fatchild/rioxx2
2 participants
@jesusbagpuss @fatchild